style(black): apply new format style from black#49
Conversation
|
Thanks for the CI noticed some issue :
I will take a look later, I believe there is a not pin dependency issue maybe related to pytest-asyncio if used. |
There was a problem hiding this comment.
I've re-read this MR several times and I'm still baffled as to why this test is failing:
=================================== FAILURES ===================================
_____________ test_Service.test_wait_first__propagates_exceptions ______________
self = <t.unit.test_services.test_Service object at 0x7f2d2cd492d0>
@pytest.mark.asyncio
async def test_wait_first__propagates_exceptions(self, *, service):
exc = KeyError("foo")
m1 = Mock()
m1.done.return_value = True
m1.exception.return_value = exc
m1.result.side_effect = exc
with patch("asyncio.wait", AsyncMock()) as wait:
wait.return_value = ((m1,), ())
with pytest.raises(KeyError):
> await service.wait_first(asyncio.sleep(5), timeout=5)
t/unit/test_services.py:629: I'll need to look around more. Sorry that such a simple change turned into this much of an inconvenience. 🤦♂️
|
No pb ! I strongly believe fixing pytest-asyncio in test to EDIT: I ran tests locally and got issue with the test |
4c3f14b to
19eae80
Compare
wbarnha
left a comment
wbarnha
left a comment
There was a problem hiding this comment.
pytest-asyncio is having some issues right now, so pinning is the right move for now. LGTM!
2 participants
Fix CI issue seen in the PR #48
(I preferred opened another PR to fix this)